Feature implementation from commits 8cc5cca..208b92b #4

codeOwlAI · 2025-06-29T22:02:49Z

PR Summary

Code Refactoring and Bug Fixes Across Multiple Components

Overview

This PR refactors several components to improve code quality and fix various issues. It includes optimization of the download progress reporting system, fixes for UI components, removal of deprecated code, and native JNI modifications.

Change Types

Type	Description
Refactor	Improved code structure in CustomSeekbar and MinecraftDownloader
Bugfix	Fixed thumb positioning in CustomSeekbar and corrected typos
Enhancement	Added download speed calculation and Android Oreo compatibility
Removal	Removed unused code and deprecated Android 10 workarounds

Affected Modules

Module / File	Change Description
`src/main/java/com/kdt/CustomSeekbar.java`	Refactored setup() method and fixed thumb positioning
`src/main/java/net/kdt/pojavlaunch/Tools.java`	Removed unused import statement
`src/main/java/net/kdt/pojavlaunch/mirrors/DownloadMirror.java`	Fixed typo in log message
`src/main/java/net/kdt/pojavlaunch/prefs/QuickSettingSideDialog.java`	Removed resolution bar scale limits
`src/main/java/net/kdt/pojavlaunch/tasks/MinecraftDownloader.java`	Refactored variables and improved download progress reporting with speed calculation
`src/main/jni/ctxbridges/gl_bridge.c`	Added new JNI function for GL4ES internals initialization
`src/main/jni/input_bridge_v3.c`	Removed deprecated functions and changed linker hook implementation

Notes for Reviewers

The resolution bar's minimum/maximum scale limits removal might allow unsafe scaling levels
Verify the Android 10 linker bug mitigation removal doesn't cause compatibility issues
Check that the new GL4ES initialization works properly across different devices

Additional Context

The changes to MinecraftDownloader improve download metrics visibility
CustomSeekbar changes add compatibility for Android 8.0 (Oreo) devices

- Add download size queries through a HEAD request - Use the file size for progress instead of file count when all file size are available - Add download speed meter

…perly.

Update GPLAY_PRIVACY_POLICY to be more clear, and remove the news entry as the news in Pojav no longer exists.

Turns out if you were perfectly still, it would fail. For a quick tap, it was fairly easy to create.

NOTE: requires a different version of the FFmpeg plugin which I haven't made yet

…efault exec mode

…stants

codeowlai · 2025-06-29T22:11:44Z

app_pojavlauncher/src/main/jni/ctxbridges/gl_bridge.c

+    void (*set_getmainfbsize)(void (*new_getMainFBSize)(int* width, int* height)) = (void*)GETSYM("set_getmainfbsize");
+    if(set_getmainfbsize != NULL) {
+        __android_log_print(ANDROID_LOG_INFO, g_LogTag, "GL4ES internals initialized dimension callback");
+        set_getmainfbsize(gl4esi_get_display_dimensions);


🐛 Correctness Issue

Undefined function reference.

The code calls gl4esi_get_display_dimensions which appears to be undefined or not declared in the visible code, potentially causing compilation errors or runtime crashes.

Current Code (Diff):

- |8 spaces| set_getmainfbsize(gl4esi_get_display_dimensions); + |8 spaces| // Ensure gl4esi_get_display_dimensions is properly defined before using it + |8 spaces| set_getmainfbsize(gl4esi_get_display_dimensions);

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

set_getmainfbsize(gl4esi_get_display_dimensions);

// Ensure gl4esi_get_display_dimensions is properly defined before using it

set_getmainfbsize(gl4esi_get_display_dimensions);

codeowlai · 2025-06-29T22:11:47Z

app_pojavlauncher/src/main/jni/ctxbridges/gl_bridge.c

+    __android_log_print(ANDROID_LOG_INFO, g_LogTag, "GL4ES internals initializing...");
+    jclass funcProviderClass = (*env)->GetObjectClass(env, function_provider);
+    jmethodID method_getFunctionAddress = (*env)->GetMethodID(env, funcProviderClass, "getFunctionAddress", "(Ljava/lang/CharSequence;)J");
+#define GETSYM(N) ((*env)->CallLongMethod(env, function_provider, method_getFunctionAddress, (*env)->NewStringUTF(env, N)));


🐛 Correctness Issue

JNI local reference leak.

The NewStringUTF call creates a local reference that's not released, which could lead to local reference table overflow in loops or long-running operations.

Current Code (Diff):

- #define GETSYM(N) ((*env)->CallLongMethod(env, function_provider, method_getFunctionAddress, (*env)->NewStringUTF(env, N))); + #define GETSYM(N) ({ jstring str = (*env)->NewStringUTF(env, N); long result = (*env)->CallLongMethod(env, function_provider, method_getFunctionAddress, str); (*env)->DeleteLocalRef(env, str); result; })

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

#define GETSYM(N) ((*env)->CallLongMethod(env, function_provider, method_getFunctionAddress, (*env)->NewStringUTF(env, N)));

#define GETSYM(N) ({ jstring str = (*env)->NewStringUTF(env, N); long result = (*env)->CallLongMethod(env, function_provider, method_getFunctionAddress, str); (*env)->DeleteLocalRef(env, str); result; })

Mathias-Boulay and others added 15 commits December 27, 2024 12:31

refactor(seekbars):migrate range values into xml files

f2e95b6

cleanup(tools): remove unused code related to fullscreen

9a7fb2a

cleanup(tools): remove unused code

99c8ea2

Feat[downloader]: downloader improvements (PojavLauncherTeam#6428)

5d80d9b

- Add download size queries through a HEAD request - Use the file size for progress instead of file count when all file size are available - Add download speed meter

Fix the issue where the long-press trigger delay does not refresh pro…

a77271d

…perly.

Fix[gestures]: rename method and improve documentation

93924b4

Style[gestures]: rename method to getGestureDelay

dd15d8a

Update GPLAY_PRIVACY_POLICY (PojavLauncherTeam#6174)

80e0a6a

Update GPLAY_PRIVACY_POLICY to be more clear, and remove the news entry as the news in Pojav no longer exists.

Fix[renderer]: move GL4ES initialization code (PojavLauncherTeam#6447)

2e596cd

fix(gesture): Right click not working

a72451c

Turns out if you were perfectly still, it would fail. For a quick tap, it was fairly easy to create.

Fix[ffmpeg_plugin]: better FFmpeg plugin insertion

0418387

NOTE: requires a different version of the FFmpeg plugin which I haven't made yet

Fix[ffmpeg_plugin]: replace LD_LIBRARY_PATH/PATH for ffmpeg, switch d…

6d39ab2

…efault exec mode

Whoops[exec_hooks]: do not null program unconditionally

aadb91d

Feat[lwjgl]: add vulkan to lwjgl dlopen hook, move hook to new file

ebe5314

Style[exec_hooks]: change function name, log lines, add clipboard con…

208b92b

…stants

codeowlai bot reviewed Jun 29, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature implementation from commits 8cc5cca..208b92b #4

Feature implementation from commits 8cc5cca..208b92b #4

Uh oh!

codeOwlAI commented Jun 29, 2025 •

edited by codeowlai bot

Loading

Uh oh!

codeowlai bot Jun 29, 2025

Uh oh!

codeowlai bot Jun 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	set_getmainfbsize(gl4esi_get_display_dimensions);
	// Ensure gl4esi_get_display_dimensions is properly defined before using it
	set_getmainfbsize(gl4esi_get_display_dimensions);

	#define GETSYM(N) ((env)->CallLongMethod(env, function_provider, method_getFunctionAddress, (env)->NewStringUTF(env, N)));
	#define GETSYM(N) ({ jstring str = (env)->NewStringUTF(env, N); long result = (env)->CallLongMethod(env, function_provider, method_getFunctionAddress, str); (*env)->DeleteLocalRef(env, str); result; })

Feature implementation from commits 8cc5cca..208b92b #4

Are you sure you want to change the base?

Feature implementation from commits 8cc5cca..208b92b #4

Uh oh!

Conversation

codeOwlAI commented Jun 29, 2025 • edited by codeowlai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Overview

Change Types

Affected Modules

Notes for Reviewers

Additional Context

Uh oh!

codeowlai bot Jun 29, 2025

Choose a reason for hiding this comment

Uh oh!

codeowlai bot Jun 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codeOwlAI commented Jun 29, 2025 •

edited by codeowlai bot

Loading